Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitLab CI doesn't run when a pull request is from a fork #81

Open
xuhdev opened this issue Dec 15, 2020 · 0 comments
Open

GitLab CI doesn't run when a pull request is from a fork #81

xuhdev opened this issue Dec 15, 2020 · 0 comments
Labels
CI Issues specific to CI. Issues that are solely on tests should be labelled "test" only, not "CI"

Comments

@xuhdev
Copy link
Collaborator

xuhdev commented Dec 15, 2020

See https://docs.gitlab.com/ee/ci/ci_cd_for_external_repos/

This feature currently does not support Pull Requests from fork repositories. Any Pull Requests from fork repositories are ignored.

We use GitLab CI for pypy tests, because GitHub actions is extremely slow for pypy tests (20min, vs GitLab CI's 3min).

This is not urgent for us, but it would matter when we start accepting pull requests from outside people.

It looks like someone has already started working on this feature: https://gitlab.com/gitlab-org/gitlab/-/issues/5667 Since it's nor urgent anyway, we can wait for a bit to see whether they would fix this issue before it becomes relevant.
@xuhdev xuhdev added the CI Issues specific to CI. Issues that are solely on tests should be labelled "test" only, not "CI" label Dec 15, 2020
@xuhdev xuhdev mentioned this issue Dec 15, 2020
Closed
20 tasks
@djalova djalova mentioned this issue Dec 15, 2020
Merged
20 tasks
xuhdev added a commit that referenced this issue Jan 6, 2021
@xuhdev
Move pypy3.6 to github actions
2a2fdb2 
Specifying a pypy version was recently supported:
actions/setup-python#168

Move away from GitLab CI due to #81

Close #81
@xuhdev xuhdev mentioned this issue Jan 6, 2021
Closed
20 tasks
xuhdev added a commit that referenced this issue Jan 6, 2021
@xuhdev
Move pypy3.6 to github actions
169e8ff 
Specifying a pypy version was recently supported:
actions/setup-python#168

Move away from GitLab CI due to #81

Close #81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Issues specific to CI. Issues that are solely on tests should be labelled "test" only, not "CI"
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move pypy3.6 to github actions CODAIT/pardata
1 participant
@xuhdev