Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated Qt function #8589

Open
afabri opened this issue Nov 6, 2024 · 4 comments
Open

Deprecated Qt function #8589

afabri opened this issue Nov 6, 2024 · 4 comments

Comments

@afabri
Copy link
Member

afabri commented Nov 6, 2024

We have a warning in this testsuite.

Lab_Demo/Plugins/PCA/Basic_generator_plugin.cpp:145:53: warning: ‘void QCheckBox::stateChanged(int)’ is deprecated: Use checkStateChanged() instead [-Wdeprecated-declarations]

But according to the Qt documentation we can replace only if we go for Qt 6.7 as minimal version, while we require only 6.4 here

@afabri
Copy link
Member Author

afabri commented Nov 8, 2024

@sloriot @lrineau do you have suggestions when is a good time to raise the minimal version?

@sloriot
Copy link
Member

sloriot commented Nov 8, 2024

6.7 was released in april 2024. It will take some time before it will be in stable debian/ubuntu repos.

@afabri
Copy link
Member Author

afabri commented Nov 8, 2024

So we might reconsider this in May 2025.

@lrineau
Copy link
Member

lrineau commented Nov 12, 2024

We could add the definition QT_WARN_DEPRECATED_UP_TO=0x60700 to the basic_generator_plugin target:

target_compile_definitions(basic_generator_plugin PRIVATE QT_WARN_DEPRECATED_UP_TO=0x60700)

That will disable the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants