Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pct_combing_weight scaling issue #256

Open
northroj opened this issue Nov 14, 2024 · 0 comments
Open

pct_combing_weight scaling issue #256

northroj opened this issue Nov 14, 2024 · 0 comments
Assignees

Comments

@northroj
Copy link
Contributor

In kernel.py

pct_combing_weight sets pc_factor with the following code:


    # Teeth distance
    td = W / M

    # Update population control factor
    mcdc["technique"]["pc_factor"] *= td  # This may be incorrect

This also applies to pct_splitting_roulette_weight

pc_factor is used to rescale weight windows at each time step


    # Population control factor
    w_target *= mcdc["technique"]["pc_factor"]

Which works for uniform combing but may be unhealthy for the weight based PCTs when combined with weight windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants