Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better logging #77

Open
loeiten opened this issue Jun 19, 2020 · 0 comments
Open

Better logging #77

loeiten opened this issue Jun 19, 2020 · 0 comments

Comments

@loeiten
Copy link
Member

loeiten commented Jun 19, 2020

The way bout_runners is logging gives the current issues:

  • If bout_runners is imported, everything is logged. For example will also the autocomplete of ipython be affected, spewing out logging everytime Tab is hit
  • pip imports bout_runners during setup, and when bout_runners/__init__.py is reached, it will call on setup_logger, which uses pyyaml which is on bare systems not present

The current workaround with try import of yaml is a bit hacky. Therefore, a possible workaround could be to use the setup similar to flake8/__init__.py.
If such a solution is chosen configure_bout_runners.py will also have to be refactored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant