-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read SQL Server #2956
base: main
Are you sure you want to change the base?
Read SQL Server #2956
Conversation
…Cgov/phdi into josh/read-sqlserver
…Cgov/phdi into josh/read-sqlserver
# Conflicts: # containers/ecr-viewer/src/app/tests/listEcrDataService.test.tsx # containers/ecr-viewer/src/app/tests/service.test.ts
if (!searchTerm) { | ||
return "NULL IS NULL"; | ||
} | ||
return `${field} LIKE '${searchTerm}'`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { | ||
convertUTCToLocalString, | ||
formatDate, | ||
formatDateTime, | ||
} from "../../services/formatService"; | ||
} from "../services/formatService"; | ||
import { database } from "../api/services/postgres_db"; | ||
|
||
describe("listEcrDataService", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get some tests here that hit the sqlserver code path? Everything being tested here is for postgres.
I was able to get the metadata to save correctly by adding
|
PULL REQUEST
Summary
If using SQL Server as the metadata database, the eCR Table can now read from it.
Related Issue
Fixes #2946
Acceptance Criteria
listEcrData
service to retrieve the necessary metadata from SQL Server to populate the eCR Library table (fromecr_data
,ecr_rr_conditions
,ecr_rr_rule_summaries
) (the same way it does for Postgres)MEATADATA_DATABASE_TYPE
Additional Information
You will need the following variables in your
.env.local
:Also to run the seed data script with SQL Server you will need to change the Orchestration config to use the
philly_ecr.json
message-parser configuation. E.g.:Checklist