Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproducing ML-KEM accumulated tests #15

Open
rben-dev opened this issue Dec 27, 2024 · 1 comment
Open

Reproducing ML-KEM accumulated tests #15

rben-dev opened this issue Dec 27, 2024 · 1 comment

Comments

@rben-dev
Copy link

Hi,

First of all, thanks for these very useful ressources.
Regarding ML-KEM accumulated test vectors, would it be possible to have the code producing these? Also, do we agree that they concern the finalized FIP-203 standard (and not the ipd draft)?

Indeed, I fail reproducing them. I would gladly put the blame on my implementation, however my results fit the hash for 10,000 iteration provided in the go reference implementation of Kyber768 where I removed the dk hash update since it is not considered there. I wonder what I might be missing for reproducing those (also, I reproduce the textual output of the reference implementation test vector of Kyber768, at least for 10,000 iterations).

PS: same issues hold at least for ML-KEM-512 accumulated hashes, but I guess the root cause would be the same.

Thanks in advance,
Regards,

@rben-dev
Copy link
Author

rben-dev commented Dec 27, 2024

Hi again,

I actually stumbled upon PR #13 after opening the current issue. I have commented this PR to confirm that for the 10k and 1M accumulated tests for the three versions of ML-KEM, I have the same results.

I leave this issue opened for now until the PR is merged for people wondering why the vectors do not match the last version of the FIPS-203 standard.

Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant