Glob `[foo` is rejected

[martinvonz]

Please tick this box to confirm you have reviewed the above.

• I have a different issue.

What version of ripgrep are you using?

ripgrep 14.1.1

How did you install ripgrep?

APT

What operating system are you using ripgrep on?

Ubuntu

Describe your bug.

Glob [foo should be interpreted as a literal [foo.

What are the steps to reproduce the behavior?

1. Run rg -g '[foo' whatever

What is the actual behavior?

$ rg -g '[foo' whatever
rg: error parsing glob '[foo': unclosed character class; missing ']'

What is the expected behavior?

It should return matches of "whatever" in the file called exactly [foo. man glob.7 doesn't seem to mention any invalid patterns. It seems that e.g. find -name '[foo' interprets it that way. Gitignores also do, apparently (this came up in jj-vcs/jj#7259).

[BurntSushi]

globset doesn't conform to any known specification. And it should by default reject malformed globa like this. I reject the Unix tradition of "make sense of anything." However, there should be an opt-in mode for this, if only to make ignore work correctly. There are 1 or 2 other bugs like this as a result of inconsistent glob implementations (like curly braces).

[martinvonz]

Thanks for the update. I don't think I myself will have time to add that mode any time soon. Hopefully someone else will. Maybe someone who's affected by it.