Porting ALL my crates to Jiff

[azzamsa]

I find Jiff API is easier and more intuitive to work with. So I ported ALL my crates from Chrono to Jiff.

• refactor: port chrono to jiff · azzamsa/zman@cf3b798. No issue at all.

• feat!: port chrono to jiff · azzamsa/nai@567a0b0. No issue at all.

• feat: upgrade to islam v4 · azzamsa/bilal@67af05b.

All the tests runs locally, but not in Github CI

command=`"/home/runner/work/bilal/bilal/target/debug/bilal" "next"`
code=101
stdout=""
stderr=```
thread \'main\' panicked at /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/jiff-0.1.4/src/civil/time.rs:327:13:
invalid hour
stack backtrace:
   0: rust_begin_unwind
   1: core::panicking::panic_fmt
   2: jiff::civil::time::Time::constant
   3: jiff::civil::date::Date::at
   4: islam::salah::times::PrayerTimes::hours_to_time
   5: islam::salah::times::PrayerTimes::new
   6: islam::salah::times::PrayerSchedule::calculate
   7: bilal::prayer::all
   8: bilal::run
   9: bilal::main
  10: core::ops::function::FnOnce::call_once
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

• feat: port chrono to jiff · azzamsa/islam@e538ff2

Testing using libfaketime stuck
Running them locally also doesn't work

git clone https://github.com/azzamsa/islam.git && cd Islam
just  _test-ignored

[BurntSushi]

Before, you had this:

time::date(time.year(), time.month(), time.day())?
            .and_hms_opt(hour as u32, minute as u32, second as u32)
            .ok_or(crate::Error::InvalidTime)

Notice the cast from hour to u32. If hour is negative, then that will silently succeed and produce a positive value.

Now compare it to what you have now:

        civil::date(time.year(), time.month(), time.day()).at(
            .and_hms_opt(hour as u32, minute as u32, second as u32)
            hour as i8,
            .ok_or(crate::Error::InvalidTime)
            minute as i8,
            second as i8,
            0,
        )

You're casting hour to an i8, which will keep the sign. I don't know what the right fix is here. You may have had a latent bug that was being hidden by Chrono.

Also, I didn't need faketime to reproduce. Just this:

$ cargo nextest run --filter-expr 'test(before_midnight)' --run-ignored ignored-only
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.00s
    Starting 1 test across 1 binary (29 skipped)
        FAIL [   0.010s] islam salah::times::tests::before_midnight

--- STDOUT:              islam salah::times::tests::before_midnight ---

running 1 test
test salah::times::tests::before_midnight ... FAILED

failures:

failures:
    salah::times::tests::before_midnight

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 29 filtered out; finished in 0.01s


--- STDERR:              islam salah::times::tests::before_midnight ---
thread 'salah::times::tests::before_midnight' panicked at /home/andrew/.cargo/registry/src/index.crates.io-6f17d22bba15001f/jiff-0.1.4/src/civil/time.rs:327:13:
invalid hour
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

   Canceling due to test failure
------------
     Summary [   0.010s] 1 test run: 0 passed, 1 failed, 29 skipped
        FAIL [   0.010s] islam salah::times::tests::before_midnight
error: test run failed

And running with faketime gives the same result:

$ faketime '2023-8-30 20:00:00' cargo nextest run --filter-expr 'test(before_midnight)' --run-ignored ignored-only
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.01s
    Starting 1 test across 1 binary (29 skipped)
        FAIL [   0.010s] islam salah::times::tests::before_midnight

--- STDOUT:              islam salah::times::tests::before_midnight ---

running 1 test
test salah::times::tests::before_midnight ... FAILED

failures:

failures:
    salah::times::tests::before_midnight

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 29 filtered out; finished in 0.01s


--- STDERR:              islam salah::times::tests::before_midnight ---
thread 'salah::times::tests::before_midnight' panicked at /home/andrew/.cargo/registry/src/index.crates.io-6f17d22bba15001f/jiff-0.1.4/src/civil/time.rs:327:13:
invalid hour
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

   Canceling due to test failure
------------
     Summary [   0.010s] 1 test run: 0 passed, 1 failed, 29 skipped
        FAIL [   0.010s] islam salah::times::tests::before_midnight
error: test run failed

I thought maybe you were misusing % instead of rem_euclid:

        let hour = (hour + is_summer as f32).floor().rem_euclid(24.0);

And what that avoids the "invalid hour" failure, it results in a test failure:

thread 'salah::times::tests::before_midnight' panicked at src/salah/times.rs:602:9:
assertion `left == right` failed
  left: Maghreb
 right: Ishaa
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

So I dunno. What the right behavior here is I think something you'll need to debug.

[azzamsa]

Turns out the root cause was libfaketime. I used the internal API for testing, and it worked well.

Thank you for being very passionate about Jiff.
Thanks a lot for Jiff! 🥞