Inspiration demo controls #5157
Conversation
|
Somehow the changes I made in another branch for status indications for pulled into this, so disregard those 😅 |
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
| static get demoProperties() { | ||
| return { | ||
| type: { type: 'select', options: ['default', 'critical', 'success', 'warning'], label: 'Alert Type' }, | ||
| subtext: { type: 'text', label: 'Subtext' }, | ||
| buttonText: { type: 'text', attribute: 'button-text', label: 'Button Text' }, | ||
| hasCloseButton: { type: 'switch', attribute: 'has-close-button', label: 'Has Close Button' }, | ||
| noPadding: { type: 'switch', attribute: 'no-padding', label: 'No Padding' } | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
This is awesome!
I don't want to make it more complex but a future idea might be allowing you to see the different types within the same demo or something. I still think there is merit in certain properties being shown simultaneously for comparison purposes
There was a problem hiding this comment.
I also am still having internal debates on this being part of the component vs part of the demo
There was a problem hiding this comment.
Yeah, I had a similar thought as well, but had decided to make it internal in the end, just so that it was all in the same place. I'd initially added these fields to the actual properties, but decided to change that since doing it like this would also allow the user to choose the order of things rather than have them be alphabetical order or anything like that (since properties are usually in alphabetical order)
I'm not sure I understand what you mean by seeing the different types within the same demo though?
There was a problem hiding this comment.
Like I mentioned in our presentation, I think there's an argument to be made that showing varieties can have value sometimes, but specific configurations should be demo-adjustable.
For example, having a click me to do x button is utilitarian (Do you need this feature or not?), but deciding which type of alert, or if you need a normal vs subtle button, may be a softer problem that having choices on-screen at the same time can help solve.
With that in mind, something like this would be extremely cool:
But I don't think that's a problem we will solve for now :D
This is an attempt at adding controls to demo components based on things set in the
demoPropertiesfield.Currently I've only added support for: