Add template parameters to mixins #5140
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
awikkerink
commented
Nov 13, 2024
helpers/composeMixins.d.ts
Outdated
There was a problem hiding this comment.
awikkerink
commented
Nov 13, 2024
| * @template {ReactiveElementClassType} S | ||
| * @param {S} superclass | ||
| */ | ||
| const InternalSkeletonGroupMixin = superclass => class extends SkeletonMixin(superclass) { |
There was a problem hiding this comment.
Using Internal mixin constant to avoid unnecessary whitespace changes.
awikkerink
commented
Nov 13, 2024
| constructor() { | ||
| super(); | ||
| constructor(...args) { | ||
| super(...args); |
There was a problem hiding this comment.
The typescript compiler is picky with mixin constructor arguments, and won't type things correctly if ...args are missing.
awikkerink
force-pushed
the
awikkerink/inspiration-add-template-parameters-to-mixins
branch
from
a8cfdb2
to
1bda15f
Compare
awikkerink
force-pushed
the
awikkerink/inspiration-add-template-parameters-to-mixins
branch
3 times, most recently
from
36b0f26
to
967d71a
Compare
awikkerink
force-pushed
the
awikkerink/inspiration-add-template-parameters-to-mixins
branch
from
967d71a
to
f9d6339
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the trickiest part to automate, but with #5139, it's possible to verify which mixins aren't typed correctly