Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d2l-input-time-range visual-diff test skipped #1749

Open
svanherk opened this issue Sep 24, 2021 · 0 comments
Open

d2l-input-time-range visual-diff test skipped #1749

svanherk opened this issue Sep 24, 2021 · 0 comments

Comments

@svanherk
Copy link
Contributor

svanherk commented Sep 24, 2021 •
edited
Loading

The opened behavior visual-diff tests for input-time-range are flakey and were skipped in #1724.

I was able to reproduce the flakiness locally pretty easily. I tried the following, and nothing consistently solved the issue:

  • Waiting an animation frame before each test
  • Adding captureBeyondViewport: false
  • Waiting for updateComplete on a number of internal elements, like the dropdown, menu, etc. before trying to measure the rect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@svanherk