Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visual-diff: get flaky tests working (dialog & dropdown-content) #1127

Open
margaree opened this issue Feb 11, 2021 · 2 comments
Open

visual-diff: get flaky tests working (dialog & dropdown-content) #1127

margaree opened this issue Feb 11, 2021 · 2 comments
Assignees
@margaree

Comments

@margaree
Copy link
Contributor

These were set to skip in here #1123. Fix the flakiness.
@margaree margaree self-assigned this Feb 11, 2021
@margaree margaree changed the title visual-diff: get flaky tests working (dialog & dropdown-content) visual-diff: get flaky tests working (dialog, dialog-fullscreen & dropdown-content) Feb 19, 2021
@margaree
Copy link
Contributor Author

Some dialog tests were re-enabled in this PR #1139

@margaree margaree changed the title visual-diff: get flaky tests working (dialog, dialog-fullscreen & dropdown-content) visual-diff: get flaky tests working (dialog & dropdown-content) Apr 18, 2022
@margaree
Copy link
Contributor Author

margaree commented Apr 18, 2022 •
edited by dlockhart
Loading

Remaining skipped tests (from this issue) are:

  • dropdown-content: scroll-top-shadow
  • dialog: scroll top shadow

@margaree margaree mentioned this issue May 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@margaree margaree

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@margaree