Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTD with CallContext when using non release build #53

Open
Eathox opened this issue Oct 29, 2024 · 3 comments
Open

CTD with CallContext when using non release build #53

Eathox opened this issue Oct 29, 2024 · 3 comments

Comments

@Eathox
Copy link
Contributor

Eathox commented Oct 29, 2024

When compiling my extension without --release any command that takes a CallContext causes an CTD.

Having the console open before the CTD shows there was a panic at: src/call_context/manager.rs:33:14

@Eathox
Copy link
Contributor Author

Eathox commented Oct 29, 2024

The culprit is very likely in lib.rs;

#[cfg(debug_assertions)]
let request_context = empty_request_context;

Is this a simple fix by removing the not(debug_assertions) clauses from from the other two request_context impls and removing this empty impl? Or are there some special cases to be considered?

@BrettMayson
Copy link
Owner

Yeah this was a workaround for testing issues, I'll try to get to this as soon as I can, but it's not a high priority for me at the moment

Why are you trying to run a debug build? Are you just profiling / debugging something while developing?

@Eathox
Copy link
Contributor Author

Eathox commented Dec 18, 2024

Yeah Its mainly so that I can use debug_assert to confirm my assumptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants