Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Build requires CheckStyle to pass, which causes issues with the autoformatter #817

Open
charlestian23 opened this issue Apr 16, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@charlestian23
Copy link
Collaborator

Description

For this action run: https://github.com/Bram-Hub/LEGUP/actions/runs/8712645184/job/23899374282?pr=812

We can see that build fails, which makes the GitHub Action for the autoformatter fail. This obviously is problematic, since the autoformatter is supposed to fix these CheckStyle issues.

Steps to Reproduce

N/A

Expected Behavior

The autoformatter should run. In this case, we should change the expected behavior of CheckStyle to not require braces when there is only 1 line inside of a code block. For example, this code should be allowed:

if (true)
     System.out.println("Hello World");

Screenshots

No response

Puzzle Files

No response

Additional Context

No response

@charlestian23 charlestian23 added bug Something isn't working good first issue Good for newcomers labels Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant