Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color-Blind friendly UI #426

Open
sparakala21 opened this issue Feb 3, 2023 · 5 comments · May be fixed by #765
Open

Color-Blind friendly UI #426

sparakala21 opened this issue Feb 3, 2023 · 5 comments · May be fixed by #765
Assignees
@FisherLuba
Labels
accessibility good first issue Good for newcomers

Comments

@sparakala21
Copy link
Collaborator

sparakala21 commented Feb 3, 2023 •
edited
Loading

Describe the current behavior of what you're trying to improve. If your enhancement request related to a problem, please also describe the problem.

Lots of LEGUP's UI is based on things lighting up red or green. The problem with that is that color blind people(like myself) have a hard time understanding when something is wrong.

Describe the improvement you'd like

Simple fixes can include changing the contrast between the reds and greens, or switching to red and blue.

High priority changes are the proof tree, short truth table rule icons and maybe the colors on the short truth table board.

Describe alternatives you've considered

No response

Additional Context

No response
@sparakala21 sparakala21 added the enhancement Improvement to existing feature label Feb 3, 2023
@charlestian23
Copy link
Collaborator

charlestian23 commented Feb 3, 2023 •
edited
Loading

Yeah, this change would be really nice (would help me as well). I think the best thing to do is to change green to blue, but that's just my suggestion. You could probably just create a setting that lets the user choose a colorblind mode if they wanted to.

@sparakala21 sparakala21 self-assigned this Feb 3, 2023
@charlestian23 charlestian23 removed the enhancement Improvement to existing feature label Feb 7, 2023
@N-Desmarais
Copy link
Collaborator

The ADA recommends against the following color combinations:
Green – Blue
Green – Yellow
Green – Red
Blue – Purple
Blue – Grey
Green – Brown
Green – Grey
Red & Blue might be a slight upgrade or maybe allow users to specify their own colors

@N-Desmarais N-Desmarais self-assigned this Feb 7, 2023
@sparakala21
Copy link
Collaborator Author

That sounds like a good idea. do you want to work on this together?

@charlestian23
Copy link
Collaborator

Specifying own colors would be a nice feature, though if that is too much work for you, we can stick to changing all instances of green to blue for now. Although, LEGUP might already have the color blue reserved for something, so you might have to pick a new color scheme. I'll leave the design up to you.

@walkingjason walkingjason self-assigned this Feb 11, 2023
@N-Desmarais
Copy link
Collaborator

You can find the colors for the proof tree in:
src/main/java/edu/rpi/legup/ui/proofeditorui/treeview/TreeTransitionView.java

The colors you should care about are CORRECT_COLOR and INCORRECT_COLOR, but you may want to play around with others to make things look nice

@N-Desmarais N-Desmarais removed their assignment Feb 17, 2023
FisherLuba added a commit to FisherLuba/LEGUP that referenced this issue Mar 19, 2024
@FisherLuba
Begin work on better color theming such as for color blindness so use…
46b7abb 
…rs can specify their own colors for Bram-Hub#426.
@FisherLuba FisherLuba self-assigned this Mar 19, 2024
@FisherLuba FisherLuba linked a pull request Mar 19, 2024 that will close this issue
Open
10 tasks
@FisherLuba FisherLuba linked a pull request Mar 26, 2024 that will close this issue
UI colors #765
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FisherLuba FisherLuba

Labels
accessibility good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UI colors FisherLuba/LEGUP
5 participants
@walkingjason @sparakala21 @charlestian23 @N-Desmarais @FisherLuba