Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errorcode To localized text #27

Open
macrojames opened this issue Feb 18, 2022 · 9 comments
Open

Errorcode To localized text #27

macrojames opened this issue Feb 18, 2022 · 9 comments
Labels
feature-request New feature requested help wanted Extra attention is needed

Comments

@macrojames
Copy link

Hi,

I had errors today on my heatpump and I wondered if there are readings for it.
I found the time and the number as errorcode and use that for now.

Then I had the idea to add the texts according to the numbers, which will be a local mapping at the moment.
I got the meanings from https://www.alpha-innotec.ch/fileadmin/content/downloads/Fehlerdiagnose_Codes_HMD2_de.pdf
and translated it to csv.
errorcodes.csv

Maybe you want to use that for localized number2text conversions?

@Bouni Bouni added enhancement Improving exsisting functionality help wanted Extra attention is needed labels Mar 25, 2022
@Bouni
Copy link
Owner

Bouni commented Mar 25, 2022

Hi,

sorry for the late feedback!

I totally agree that having error texts rather than just plain numbers would be great!
But I defenitely want to have them as translations so that we can support multiple languages.
To be honest, I've never looked into the way the Home Assistant folks do translations in integrations.
It would be nice if we can do it th right way directly from the start!

https://developers.home-assistant.io/docs/internationalization/custom_integration/

Would you dig into this and create a PR?

@Bouni
Copy link
Owner

Bouni commented Mar 25, 2022

🤦🏽‍♂️ Oh man, wrong repo for HA translations. I think we should do the translation over in the HA integration repo

@Kh3nsu
Copy link

Kh3nsu commented Apr 24, 2022

Hey this is exactly what I'm looking for at the moment!
Is the translation already implemented for the error codes? :D

@macrojames
Copy link
Author

I could not look into this. I tried implementing the localalized json files on another project some time ago but I failed. I can't invest the time right now to dig deeper into this, sorry.

@Bouni
Copy link
Owner

Bouni commented Apr 26, 2022

I defenitely will take a look at it but that will take some time, my backlog is getting bigger and bigger every week 🙈

@kbabioch
Copy link
Collaborator

kbabioch commented May 5, 2022

Is the idea to have those error codes translated in the core Python library (i.e. here), or in the Home Assistant integration?

@Bouni
Copy link
Owner

Bouni commented May 9, 2022

@kbabioch Actually I'm not sure where the best place is to have translations. If you have an opinion, feel free to share it with me as I've no experiance so far with translations

@BenPru
Copy link
Collaborator

BenPru commented Jan 11, 2023

@kbabioch Currently I'm extending my ha integration (luxtronik2) with a "sensor.luxtronik2_switchoff_reason" and "sensor.luxtronik2_error_reason".
The plan is to use the ha translation to solve the error code into the error description, cause and remedy.
Cause and remedy are attributes. At the moment ha 2023.01.* can only translate attributes and attribute values for climate enties but I think its coming soon.
Cause=717 is replaced with "Durchfluss zu gering"
Remedy=717 is replaced with "HUP/ZUP auf Funktion prüfen, Volumenstrom der HUP/ZUP erhöhen"
image

@Bouni Bouni added feature-request New feature requested and removed enhancement Improving exsisting functionality labels Jan 20, 2023
@kbabioch
Copy link
Collaborator

I think that we should provide this functionality in this repository. Home Assistant can then reuse or reimplement it, but core functionality should not be handled somewhere.

gerw added a commit to gerw/python-luxtronik that referenced this issue Feb 22, 2024
gerw added a commit to gerw/python-luxtronik that referenced this issue Feb 23, 2024
Bouni pushed a commit that referenced this issue Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature requested help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants