Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create base class for Calculations, Parameters, Visibilities #122

Closed
gerw opened this issue Jul 16, 2023 · 0 comments · Fixed by #129
Closed

Create base class for Calculations, Parameters, Visibilities #122

gerw opened this issue Jul 16, 2023 · 0 comments · Fixed by #129
Labels
cleanup Cleanup existing code code-quality Keep code quality high or improve it
Milestone
Basic refactoring...

Comments

@gerw
Copy link
Collaborator

gerw commented Jul 16, 2023

These three classes share a good amount of code. There should be a common base class from which these three are inherited.
@gerw gerw added cleanup Cleanup existing code code-quality Keep code quality high or improve it labels Jul 16, 2023
This was referenced Jul 16, 2023
Merged
Merged
@gerw gerw linked a pull request Jul 22, 2023 that will close this issue
Common base class for Parameters,Calculations,Visibilities #129
Merged
@gerw gerw closed this as completed in #129 Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Cleanup existing code code-quality Keep code quality high or improve it
Projects
None yet
Milestone
Basic refactoring and improvements
Development

Successfully merging a pull request may close this issue.

Common base class for Parameters,Calculations,Visibilities gerw/python-luxtronik
2 participants
@gerw @kbabioch