Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General Cleanup #151

Open
double-fault opened this issue Jan 12, 2017 · 4 comments
Open

General Cleanup #151

double-fault opened this issue Jan 12, 2017 · 4 comments
Assignees
@srifqi @double-fault
Labels
in progress Low Priority

Comments

@double-fault
Copy link
Member

The formatting in the code of BoneOS is horrible. Need to do that properly
@double-fault double-fault self-assigned this Jan 12, 2017
double-fault added a commit that referenced this issue Jan 12, 2017
@double-fault
Some more cleanup #151
1fa4907
double-fault added a commit that referenced this issue Jan 12, 2017
@double-fault
Merge pull request #152 from Bone-Project/dev
5a88d2b 
Some more cleanup #151
double-fault added a commit that referenced this issue Jan 12, 2017
@double-fault
Some more cleanup #151
6413b15
@srifqi
Copy link
Collaborator

srifqi commented Jan 12, 2017

Is there any formatting guide? So that other developer may help too.

@double-fault
Copy link
Member Author

@srifqi What most IDE's will give. TABs should be four spaces, and increase readability of code, add newlines wherever required. See the commits I have done to get an idea.

I'm assigning this to you now, assuming you will do it. If you can't, post a comment here.

double-fault added a commit that referenced this issue Jan 14, 2017
@double-fault
cleanup #151
f14baa7
@srifqi
Copy link
Collaborator

srifqi commented Jan 15, 2017

Well, my text editor uses Tab character instead of four spaces. Should I do Find and Replace?

@double-fault
Copy link
Member Author

@srifqi Well, when you press the "TAB" key, it puts 2, 4 or 8 spaces. I'm telling that you should put 4 by changing the settings of your text editor.

srifqi added a commit to srifqi/BoneOS that referenced this issue Jan 16, 2017
@srifqi
General Cleanup Bone-Project#151
c24ca75 
Uses 4 spaces as TAB.
Commenting unused code. (i.e. if statement with no action)

apps/
boot/
platform/
sbin/
var/
srifqi added a commit to srifqi/BoneOS that referenced this issue Jan 16, 2017
@srifqi
General Cleanup Bone-Project#151
f2f2c77 
Uses 4 spaces as TAB.
Commenting unused code. (i.e. if statement with no action)

apps/
boot/
platform/
sbin/
var/
srifqi added a commit to srifqi/BoneOS that referenced this issue Jan 16, 2017
@srifqi
General Cleanup Bone-Project#151
a52f8be 
Uses 4 spaces as TAB.
Commenting unused code. (i.e. if statement with no action)

apps/
boot/
platform/
sbin/
var/
double-fault added a commit that referenced this issue Jan 16, 2017
@double-fault
Merge pull request #160 from srifqi/srifqi_dev
d4232bd 
Some General Cleanup #151 (Part 1)
@srifqi srifqi mentioned this issue Jan 18, 2017
Merged
amanuel2 pushed a commit that referenced this issue Jan 22, 2017
@double-fault
Some more cleanup #151
ba656ec
amanuel2 pushed a commit that referenced this issue Jan 22, 2017
@double-fault
Merge pull request #152 from Bone-Project/dev
c25047c 
Some more cleanup #151
amanuel2 pushed a commit that referenced this issue Jan 22, 2017
@double-fault
Some more cleanup #151
3ffa39d
amanuel2 pushed a commit that referenced this issue Jan 22, 2017
@double-fault
cleanup #151
59ee6d5
amanuel2 pushed a commit that referenced this issue Jan 22, 2017
@srifqi
General Cleanup #151
6be4495 
Uses 4 spaces as TAB.
Commenting unused code. (i.e. if statement with no action)

apps/
boot/
platform/
sbin/
var/
amanuel2 pushed a commit that referenced this issue Jan 22, 2017
@double-fault
Merge pull request #160 from srifqi/srifqi_dev
197e847 
Some General Cleanup #151 (Part 1)
double-fault added a commit that referenced this issue Feb 7, 2017
@double-fault
Some more command error support #194, some cleanup too #151
325dab2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srifqi srifqi

@double-fault double-fault

Labels
in progress Low Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srifqi @double-fault