Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-ups to #261 #291

Open
real-or-random opened this issue Mar 5, 2024 · 0 comments
Open

Follow-ups to #261 #291

real-or-random opened this issue Mar 5, 2024 · 0 comments

Comments

@real-or-random
Copy link
Collaborator

real-or-random commented Mar 5, 2024

I have a few nits that can be cleaned up in a separate PR. Your detailed and helpful comments in the main code and tests is very much appreciated.

Nits:

  • we may want to add a header to the include file that links to the BIP
  • there's still a mention of aggsig_size
  • we may want to move aggregate before inc_aggregate
  • we should mention expected size of input aggsig array in_aggregate
  • "Should be aggsig_len = 32*(n+1)" -> "Must be"

Originally posted by @jonasnick in #261 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant