Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all commits signed by contributor PGP keys from Keybase.io #7

Open
1 of 3 tasks
heri16 opened this issue Oct 25, 2018 · 1 comment
Open
1 of 3 tasks
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@heri16
Copy link
Contributor

heri16 commented Oct 25, 2018

Description

All commits pushed to GitHub should be cryptographic signed by the developer PGP keys that are published on Keybase.io .

This should apply to all contributors as standard Git commits are inherently weak against identity spoofing / impersonation.

The Heartbleed Openssl incident teaches us that it would be bad if we could not trace exactly who made the changes that led to the vulnerability.

See: https://help.github.com/articles/signing-commits/

  • Make all contributors signup for Keybase.io and completed the attestation steps
  • Create Setup guide for automatic commit signing with git
  • Retroactively sign all past commits
@heri16 heri16 added help wanted Extra attention is needed good first issue Good for newcomers labels Oct 25, 2018
@heri16 heri16 self-assigned this Oct 25, 2018
@heri16 heri16 changed the title Ensure all commits signed by developer Keybase keys Ensure all commits signed by contributor PGP keys from Keybase.io Oct 25, 2018
@heri16
Copy link
Contributor Author

heri16 commented Nov 29, 2018

Decided to use codesign feature of https://github.com/kryptco/kr for better security of PGP keys and easier developer setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant