Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Can direct loading of Savestates (.uss files) be improved? #1565

Closed
giantclambake opened this issue Jan 3, 2025 · 4 comments
Closed
Assignees
Labels

Comments

@giantclambake
Copy link

I've noticed that when you direct-load a .uss file, it always starts in Windowed mode, regardless of what any associated config.uae has configured...ie; Full-window ...

I've come to understand this, to be the .uss file contains the emulation state, but Windowed/Full-window/Fullscreen is not part of emulation...it's more an 'SDL state' if you will... we may understand this ~ my hunch is there'll be a number of users who would think the .uss file, 'preserves' the screenmode 'state' as well....

...in testing...

Stunt Car Racer (1989)(Micro Style).uae -- a config.uae file of a well known .adf title, with the option Full-window set

Stunt Car Racer (1989)(Micro Style)-4.uss -- a savestate file created with title in Full-window mode using said config.uae

amiberry "Stunt Car Racer (1989)(Micro Style)-4.uss" -- direct loads .uss file, starts emulation in Windowed mode

Using the 'established' savestate loading syntax...

amiberry --config "Stunt Car Racer (1989)(Micro Style).uae" --statefile "Stunt Car Racer (1989)(Micro Style)-4.uss" -G

....it direct loads config.uae file, >then> .uss file, and starts emulation in Full-window mode = Desired result.

Wrt direct-loading .uss files, with an associated config.uae file that has Full-window mode set, the user currently has a couple of options to deal with this...

  • manually edit amiberry.conf and set default_fullscreen_mode=2 ....or...
  • manually edit amiberry.conf and set default_fullscreen_toggle_key= ....or...
  • use F12 to pop the GUI, Display panel, use dropdown selector for Full-window mode ;)

The only way this situation can manifest itself, is if the associated config.uae file contains gfx_fullscreen_amiga=fullwindow
This infers, the associated config.uae file must exist (because default is gfx_fullscreen_amiga=false and this situation is moot ;)

My question is, when direct loading a .uss file, can amiberry search /conf for an associated config.uae file (of the same name), and load that first before starting the emulation from the savestate file, so it can detect what screenmode to use for the emulation window? ...ie; just like the 'established' cmdline does??...

TIA

@midwan midwan self-assigned this Jan 5, 2025
@midwan midwan added the question label Jan 5, 2025
@midwan
Copy link
Collaborator

midwan commented Jan 6, 2025

I'm not sure it's a good idea, to load a config after loading a save state.
The saved state contains a snapshot of the "virtual Amiga" at the time it was taken. Loading a config might change a setting, which could break things.

@giantclambake
Copy link
Author

Specifically it's only the Windowed/Full-window/Fullscreen mode selection I'm thinking about...

amiberry --config "Stunt Car Racer (1989)(Micro Style).uae" --statefile "Stunt Car Racer (1989)(Micro Style)-4.uss" -G

.....In this case, which is loaded first?...config.uae or .uss file?

I'm not sure it's a good idea, to load a config after loading a save state.

Hence the above question .... config.uae is loaded before .uss file ....(not the other way around ;)

I do understand what you're saying (I've already documented as much).... but going by your answer, I'd have to include...

Note: When direct-loading a savestate file, it will always start in Windowed mode regardless of config.uae settings. To have a savestate file start in Full-window or Fullscreen mode when direct loading, you must have amiberry set to start in Full-window or Fullscreen mode, by editing amiberry.conf ....

If you're okay with that, then not a problem.... but folks who run amiberry in Windowed mode, and direct load a .uss file are stuck with the above to get emulation to Full-window/Fullscreen mode ;

manually edit amiberry.conf and set default_fullscreen_mode=2 ....or...
manually edit amiberry.conf and set default_fullscreen_toggle_key= ....or...
use F12 to pop the GUI, Display panel, use dropdown selector for Full-window mode ;)

You okay with that?

@midwan
Copy link
Collaborator

midwan commented Jan 6, 2025

I think that's OK for now.
If people want to be running things in full-window, they can always set that as the default. Otherwise, they expect to get a windowed output anyway, so the save states will honor that behavior.

Alternatively, as you mentioned above, they can set a key to toggle windowed <-> full-window mode.

@giantclambake
Copy link
Author

Ok, thanks for confirming ~ fwiw I do concur, (and very much why I always say, wrt desktop usage, the variables default_fullscreen_toggle_key & default_quit_key ...are very much your friends ;)

Closing as answered..."let no rock go un-turned" =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants