New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlinkyTape: firmwareName and maxBrightness should be part of scene #183

Open

cibomahto opened this issue Jan 31, 2017 · 1 comment

Labels

Member

cibomahto commented Jan 31, 2017

For expediency, the firmware name and brightness are being stored as global parameters:
https://github.com/Blinkinlabs/PatternPaint/blob/master/src/app/gui/mainwindow.cpp#L1212
https://github.com/Blinkinlabs/PatternPaint/blob/master/src/app/gui/preferences.cpp#L30

The scene template should kept around by the main process, and these parameters should be stored in it instead.

cibomahto added the enhancement label

cibomahto mentioned this issue

Add support for alternate matrix layout #143

Closed

Member Author

cibomahto commented Feb 5, 2017

This would also allow us to implement the different matrix types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment