Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern resize works inconsistently #174

Open
cibomahto opened this issue Jan 16, 2017 · 1 comment
Open

Pattern resize works inconsistently #174

cibomahto opened this issue Jan 16, 2017 · 1 comment
Labels

Comments

@cibomahto
Copy link
Member

screen shot 2017-01-16 at 2 28 08 pm

Patterns are automatically resized to fit the height of the fixture. Unfortunately the way this is implemented is not consistent. To repeat:

  1. From welcome screen, select blinkytape configuration and load sample patterns
  2. Resize fixture to have height 475
  3. Patterns will be stretched vertically but not horizontally
  4. load cylon example
  5. Newly loaded cylon pattern will be stretched both vertically and horizontally

Should probably implement a better scene configuration tool to really fix this

@cibomahto cibomahto added the bug label Jan 16, 2017
@cibomahto
Copy link
Member Author

The scaling is indeed implemented through different paths.

The resize that occurs when loading a new pattern is handled through pattern::load():

bool Pattern::load(const QString &newFileName)

The reisze that occurs through changing a scene is handled through Pattern::sresize():

pattern->resize(newDisplaySize, false);

void Pattern::resize(QSize newSize, bool scale)

Unfortunately, the 'scale' parameter is not implemented, so that's probably where to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant