Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probable mistake in Eq. 16 in the preprint #238

Open
zeyun-zhong opened this issue Apr 21, 2024 · 2 comments
Open

Probable mistake in Eq. 16 in the preprint #238

zeyun-zhong opened this issue Apr 21, 2024 · 2 comments

Comments

@zeyun-zhong
Copy link

Thank you for the great work.

I have checked the code and the paper, and I believe that the "lerp" in Eq. 16 might actually be "ddlerp".

@UEA-GCG
Copy link

UEA-GCG commented Apr 23, 2024

I also find the code uses ddlerp method. I also think Eq.19 also doesn't match the Table 7.

@SmerkyG
Copy link

SmerkyG commented Apr 30, 2024

@zeyun-zhong You are correct, thanks for noticing this! We will update the paper.

@UEA-GCG Thank you for finding this error. I believe you are pointing out that the cumprod in Eq. 19 is indexed incorrectly. (It should go from j=i+1 to t-1, since it's really a reverse cumprod). Please let me know whether you see some other issue(s) as well with this formula.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants