Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRNLIB_ASSERT(num_threads <= cMaxThreads) fails on many-proc computers #39

Open
shinymerlyn opened this issue Jul 24, 2021 · 0 comments

Comments

@shinymerlyn
Copy link

shinymerlyn commented Jul 24, 2021

I managed to "fix" this locally by bumping the cMaxThreads value in crn_threading_win32.h to 64.
Is it safe to bump this? Is it just for a sanity check, or are other things driven by it somehow?

Note: Could be this is a bug in an old version of the library. Haven't tried to repro on latest main branch here, since this is a very legacy project.

The offending line seems to be:
https://github.com/BinomialLLC/crunch/blob/master/crnlib/crn_image_utils.cpp#L605
It's not using the crn_get_max_helper_threads function when calling task_pool tp; tp.init(g_number_of_processors - 1);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant