-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting random polka dots on some mipmap levels #31
Comments
The problem might be linked to parallelisation of treating a lot of files. We convert them to dxt, etc, pvrtc, astc and basis all in parallel. In our logs, we can see basisu failing at the same time one of the dxt file is being treated. Just like the dots, it happens at random and only some basis convertion failed. |
The lightmap with a mipmap with dark stripes: https://storage.3d.io/ace/job/2021-01-19/12-04_9c8a5868/lm_1__1.hi-res.gz.dds |
"The problem might be linked to parallelisation of treating a lot of files. We convert them to dxt, etc, pvrtc, astc and basis all in parallel. In our logs, we can see basisu failing at the same time one of the dxt file is being treated" Is this issue occurring with basisu.exe, or crunch? The best way (from a perf perspective) to multithread either tool is to disable threading and launch them X times (i.e. running X encodes in parallel). So does the problem go away when you disable threading? |
Also, note that basisu's threading is implemented in a completely different way vs. crunch. crunch uses completely custom code that leverages the Win32/pthread API's, and basisu uses C++11 std helpers to implement a thread pool with simple jobs. |
It's happening with crunch, with only the DXT1 conversion running. It's on Linux (Ubuntu 18.04). |
Strange - on Linux it uses the pthread API's. It's been many years since I've looked at the crunch codebase, but whatever is happening seems rare. We have some extremely large commercial users of the crunch lib who haven't reported it. |
There's a decent probability that the issue is in here or the header: |
Hi, I'm having a weird issue where I get some colored dots added to some mipmap levels of my textures. It appears to be pretty random: those textures were converted automatically by our scripts on a server, but if I try to convert them locally on my computer with the same parameters, I don't have the issue. Additionnaly, some textures have the problem and some don't (for example, the floor has been treated the same way and is fine)
The text was updated successfully, but these errors were encountered: