Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Self assignment creating possible bug #3

Open
Leandros opened this issue Jun 30, 2016 · 0 comments
Open

Self assignment creating possible bug #3

Leandros opened this issue Jun 30, 2016 · 0 comments

Comments

@Leandros
Copy link
Contributor

In crn_tree_clusterizer.h are multiple self-assignments (starting with line 421), assigning left_weight and right_weight to itself.

Either, the assignment was meant to assign to another variable or it's superfluous. Either way, it should be fixed. I would send you a PR, but due to not knowing what was intended, I leave it untouched for now.
illwieckz pushed a commit to illwieckz/crunch that referenced this issue May 5, 2018
@slipher
Merge pull request BinomialLLC#3 from DaemonEngine/slipher/unity-warn…
f6e48df 
…ings

Fix warnings introduced by Unity changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Leandros