Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limits Bug | Chestpreview #196

Open
BerndPixel opened this issue Sep 15, 2024 · 2 comments
Open

Limits Bug | Chestpreview #196

BerndPixel opened this issue Sep 15, 2024 · 2 comments
Assignees
Labels
conflict conflict with another plugin under investigation this is being looked into

Comments

@BerndPixel
Copy link

Expected behavior

That you can preview the chest and the limit does not increase by itself because the hologram is there.

Observed/Actual behavior

I use the Limits addon from BentoBox, now I have the additional plugin ChestPreview (https://www.spigotmc.org/resources/chestpreview.113793/) and there are some problems with it. If the plugin ChestPreview is active, the BentoBox addon Limits increases the limit for some values and also saves them, although no blocks are placed. In other words, if the box only displays a preview, the limit is increased. This does not always happen, but it does happen regularly. I then have to shut down the server and edit the database so that the limit is back to normal.

Steps/models to reproduce

1.) look at a crate where the crate preview can be seen.
2.) !!!this does not always happen!!! the limit of certain blocks (which were visible in the preview) increases automatically, even though the block was not placed on the island.
3.) At some point the player receives a message that the limit has been reached.

BentoBox version

Ausführen von PAPER 1.21.1.
(1.21.1-77-4ff58c4 (MC: 1.21.1))
BentoBox version: 2.5.2
Datenbank: JSON
Geladene Spielewelten:
skyblock_world (OneBlock): Oberwelt, Nether, End
Geladene Addons:
AOneBlock 1.17.1-SNAPSHOT-b413 (ENABLED)
Bank 1.8.0-SNAPSHOT-b97 (ENABLED)
Biomes 2.2.0-SNAPSHOT-b276 (ENABLED)
Border 4.3.1-SNAPSHOT-b212 (ENABLED)
ControlPanel 1.13.1 (ENABLED)
DimensionalTrees 1.7.0 (ENABLED)
ExtraMobs 1.13 (ENABLED)
FarmersDance 1.1.0 (ENABLED)
IslandFly 1.13.0 (ENABLED)
Level 2.16.0-SNAPSHOT-b592 (ENABLED)
Limits 1.22.0 (ENABLED)
TopBlock 1.0.2-SNAPSHOT-b27 (ENABLED)
Visit 1.7.0-SNAPSHOT (ENABLED)

Plugin list

Not important. The only important things are:
BentoBox, the addons and ChestPreview

Other

No response

@tastybento tastybento self-assigned this Sep 15, 2024
@tastybento tastybento added the under investigation this is being looked into label Sep 15, 2024
@tastybento
Copy link
Member

The Plugin you mention is closed source and so I cannot study the code to see where the issue may be. However, there is a way to file bugs with them - https://github.com/PluginBugs/Issues-ChestPreview/issues/new/choose or on the author's Discord server. I recommend you do that and try to find out why he thinks Limits may be triggering.

The Limits check on Blocks are triggered by these events:

  1. BlockPlaceEvent - normally only fired when the player places a block.
  2. PlayerInteractEvent - only applicable to Turtle Eggs, so I doubt this is related.
  3. BlockMultiPlaceEvent - Fired when a single block placement action of a player triggers the creation of multiple blocks(e.g. placing a bed block).

The above have links to the listeners. I am open to making tweaks to be compatible, but unless I know what to do, I cannot. Good luck!

@LoneDev6
Copy link

Probably related to this: PluginBugs/Issues-ChestPreview#15 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflict conflict with another plugin under investigation this is being looked into
Projects
None yet
Development

No branches or pull requests

3 participants