Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recount command works bad #123

Open
VozikCZE opened this issue Mar 2, 2021 · 8 comments
Open

Recount command works bad #123

VozikCZE opened this issue Mar 2, 2021 · 8 comments
Assignees
@tastybento
Labels
bug Something isn't working in progress being worked on

Comments

@VozikCZE
Copy link

VozikCZE commented Mar 2, 2021

Description
Command for recount limit works only sometimes.

Steps to reproduce the behavior:

  1. Use /bsb limits calc or /is limits recount
  2. Wait.
    Nothing will usually happen, it only sometimes recount the level - I trying to find when it recount, but I didin't find any reason yet.

Expected behavior
It should recount limits with some messages in chat like "Recounting island level... Estimated time: 50 seconds"

Server Information:

[Please complete the following information:]
[09:55:16 INFO]: Běžím na Neplatné (PURPUR) Neplatné.
[09:55:16 INFO]: Verze BentoBox: 1.15.5
[09:55:16 INFO]: Databáze: MYSQL
[09:55:16 INFO]: Načtené herní světy:
[09:55:16 INFO]: bskyblock_world (BSkyBlock): Svět, Nether, End
[09:55:16 INFO]: Načtené doplňky:
[09:55:16 INFO]: BSkyBlock 1.14.3 (ENABLED)
[09:55:16 INFO]: Chat 1.1.2 (ENABLED)
[09:55:16 INFO]: EpicHooks 1.1.0-SNAPSHOT-b5 (ENABLED)
[09:55:16 INFO]: Greenhouses 1.5.1-SNAPSHOT-b287 (ENABLED)
[09:55:16 INFO]: Level 2.5.0 (ENABLED)
[09:55:16 INFO]: Limits 1.15.0 (ENABLED)
[09:55:16 INFO]: Warps 1.9.7 (ENABLED)
@tastybento tastybento added the bug Something isn't working label Mar 3, 2021
@ChimpGamer
Copy link

If I check /is top the amount of hoppers is not the same with /is limits even after executing /is limits recount.
image
image

@VozikCZE
Copy link
Author

VozikCZE commented May 6, 2021

Limits have more problems with bad counting.

@tastybento
Copy link
Member

Yes. It needs reworking to essentially use the same code as Level. It's on the list.

@VozikCZE
Copy link
Author

@tastybento I think this is important issue and it should be fixed soon.. some players are stuck because they have wrong count in /is limits and they can't recount it.

@tastybento
Copy link
Member

Okay. I'll see what I can do.

tastybento added a commit that referenced this issue Dec 26, 2021
@tastybento
Improved recount code. Should be accurate.
343d7bb 
This uses the latest approach done by Level addon. This does not yet
include entity recounting!

#123
@tastybento tastybento self-assigned this Dec 26, 2021
@tastybento tastybento added the in progress being worked on label Dec 26, 2021
@tastybento
Copy link
Member

tastybento commented Dec 26, 2021 •
edited
Loading

This update should fix the block recounting. Note that it recounts for overworld, nether, and end, if they are enabled. Localization of some of the text is not done yet. In other words, this is still a work in progress.

tastybento added a commit that referenced this issue Dec 27, 2021
@tastybento
Added locale text
d8c8102 
#123
@tastybento
Copy link
Member

@VozikCZE Okay, please try the snapshot and let me know if it works for you.

@VozikCZE
Copy link
Author

@tastybento Sorry for the delay.. It works slowly, but works :D Also it doesn't have any spam protection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tastybento tastybento

Labels
bug Something isn't working in progress being worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tastybento @ChimpGamer @VozikCZE