Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not show Challenges that are not deployed. #175

Open
Waterman1001 opened this issue Aug 31, 2019 · 10 comments
Open

Not show Challenges that are not deployed. #175

Waterman1001 opened this issue Aug 31, 2019 · 10 comments
Assignees
@BONNe
Labels
Status: Under investigation Investigating the interest and the feasability of the issue. Type: Enhancement Improvement or modification which is usually a new feature.
Milestone
Challenges 0.8.0 ...

Comments

@Waterman1001
Copy link

Description

Is your feature request related to a problem?

Players currently are still able to see challenges that are not deployed.

Describe the solution you'd like us to implement.

It would be nice to have an option, just like the biomes addon, such that people are not able to see those challenges anymore when they are not deployed.
@BONNe BONNe self-assigned this Aug 31, 2019
@BONNe BONNe added this to the Challenges 0.8.0 Release milestone Aug 31, 2019
@wellnesscookie
Copy link
Contributor

If this would be toggleable, then yes, I'd like this too.
We use locked (not deployed) challenges and display on purpose for some things.

@BONNe
Copy link
Member

BONNe commented Sep 4, 2019 •
edited
Loading

This feature was not intended to use it like that @wellnesscookie
😡😡😡😡

😁

@wellnesscookie
Copy link
Contributor

Buut, it's really cool to have it! If you would let me try to explain what we do:

We implement a challenge and make it undeployed. We write that the challenge will unlock on DD.MM.YYYY in HH:MM and our players prepare for it. We say them that it will last only for 2 hours, so they prepare as many materials as they can to complete it.

It gets our players hyped and interested in always checking the GUI for something new! :)

@BONNe
Copy link
Member

BONNe commented Sep 4, 2019

oOo,
If you write FR, I could implement it so it becomes deployed automatically when time is reached.

@wellnesscookie
Copy link
Contributor

Yes, but it would be kinda useless if you make it invisible when undeployed. We want them to see it but not do it as well

@BONNe
Copy link
Member

BONNe commented Sep 4, 2019

When i will implement it, it will be the same as it is in Biomes.

  • Visible,
  • Invisible,
  • Toggle.

@BONNe
Copy link
Member

BONNe commented Sep 5, 2019

Should undeployed challenges count in the uncompleted challenge list that prevents from unlocking next level?

@wellnesscookie
Copy link
Contributor

As for me, yes.

@Waterman1001
Copy link
Author

For me, it doesn't really matter.
I know that in the current situation they do count. For this reason I configured it this way.
But I can change my configuration if needed since I think it makes more sense that if a challenge is not deployed and thus kind of 'unavailable', it also does not count as an uncompleted challenge.
I do understand the opinion of wellnesscookie because of the way he uses the feature

This was referenced Sep 5, 2019
Open
Open
BONNe added a commit that referenced this issue Sep 5, 2019
@BONNe
Add an option to hide undeployed challenges from challenge list (#175)
643c5e8 
Added new config option "gui-settings.undeployed-view-mode" with 3 values
- 'VISIBLE' - all challenges are visible
- 'HIDDEN' - only deployed challenges are visible
- 'TOGGLEABLE' - users will be able to choose option for themself (not implemented)

Implement functionality in ChallengesGUI, where if option hidden is set, then all undeployed challenges are removed.
Implement ability to edit this option via admin Settings panel.
@BONNe
Copy link
Member

BONNe commented Sep 5, 2019

Partially implemented in build #365
Not sure how to implement the toggleable option.

@BONNe BONNe added Status: Under investigation Investigating the interest and the feasability of the issue. Type: Enhancement Improvement or modification which is usually a new feature. labels Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BONNe BONNe

Labels
Status: Under investigation Investigating the interest and the feasability of the issue. Type: Enhancement Improvement or modification which is usually a new feature.
Projects
Global BentoBox Enhancements To Do List
Status: No status
Milestone
Challenges 0.8.0 Release
Development

No branches or pull requests
3 participants
@BONNe @Waterman1001 @wellnesscookie