Merge pull request #2513 from BentoBoxWorld/2512_random_errors

NPE fix for #2512

Author: tastybento

src/main/java/world/bentobox/bentobox/listeners/flags/protection/BreakBlocksListener.java

@@ -84,6 +84,9 @@ public void onBreakHanging(final HangingBreakByEntityEvent e) {
     @EventHandler(priority = EventPriority.LOW, ignoreCancelled = true)
     public void onPlayerInteract(final PlayerInteractEvent e)
     {
+        if (e.getClickedBlock() == null) {
+            return;
+        }
         Player p = e.getPlayer();
         Location l = e.getClickedBlock().getLocation();
         Material m = e.getClickedBlock().getType();
@@ -95,7 +98,7 @@ public void onPlayerInteract(final PlayerInteractEvent e)
                 if (((CaveVinesPlant) e.getClickedBlock().getBlockData()).isBerries()) {
                     this.checkIsland(e, p, l, Flags.HARVEST);
                 }
-                }
+            }
             case SWEET_BERRY_BUSH -> this.checkIsland(e, p, l, Flags.HARVEST);
             case ROOTED_DIRT -> this.checkIsland(e, p, l, Flags.BREAK_BLOCKS);
             default -> { // Do nothing

src/test/java/world/bentobox/bentobox/listeners/flags/protection/BreakBlocksListenerTest.java

@@ -621,4 +621,15 @@ public void testLeftClickHopper() {
 
         assertTrue(e.useInteractedBlock() == Result.ALLOW);
     }
+
+    /**
+     * Test method for {@link world.bentobox.bentobox.listeners.flags.protection.BreakBlocksListener#onPlayerInteract(PlayerInteractEvent)}
+     */
+    @Test
+    public void testNoClick() {
+        PlayerInteractEvent e = mock(PlayerInteractEvent.class);
+        when(e.getClickedBlock()).thenReturn(null);
+        bbl.onPlayerInteract(e);
+        verify(e).getClickedBlock();
+    }
 }