Merge pull request #2505 from BentoBoxWorld/2504_lag_on_logout

Make the rank clearing async to avoid lag. #2504

Author: tastybento

src/main/java/world/bentobox/bentobox/managers/IslandsManager.java

@@ -1650,6 +1650,10 @@ public void clearArea(Location loc) {
      * @param uniqueId - UUID of player
      */
     public void clearRank(int rank, UUID uniqueId) {
+        Bukkit.getScheduler().runTaskAsynchronously(plugin, () -> clearRankSync(rank, uniqueId));
+    }
+
+    void clearRankSync(int rank, UUID uniqueId) {
         islandCache.getCachedIslands().forEach(
                 i -> i.getMembers().entrySet().removeIf(e -> e.getKey().equals(uniqueId) && e.getValue() == rank));
     }

src/test/java/world/bentobox/bentobox/managers/IslandsManagerTest.java

@@ -1111,9 +1111,9 @@ public void testClearRank() {
         UUID coopUUID = UUID.randomUUID();
         members.put(coopUUID, RanksManager.COOP_RANK);
         // Clear a random user
-        im.clearRank(RanksManager.COOP_RANK, UUID.randomUUID());
+        im.clearRankSync(RanksManager.COOP_RANK, UUID.randomUUID());
         assertEquals(14, members.size());
-        im.clearRank(RanksManager.COOP_RANK, coopUUID);
+        im.clearRankSync(RanksManager.COOP_RANK, coopUUID);
         assertEquals(13, members.size());
     }