Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

potential for errors due to inconsistent string case from namecheap's api ? #20

Open
jvanasco opened this issue Feb 16, 2018 · 1 comment
Open

potential for errors due to inconsistent string case from namecheap's api ? #20

jvanasco opened this issue Feb 16, 2018 · 1 comment

Comments

@jvanasco
Copy link

While working with this library, I noticed that namecheap doesn't have a standard use of case. Sometimes an attribute is ERROR and other times it is Error. False + false, and OK + Ok are used interchangeably in a few areas too.

I don't know how stable this is across versions, but It might make sense to change the string comparisons to a case insensitive match in case they decide to standardize things.
@agrrh
Copy link
Contributor

agrrh commented Feb 17, 2018 •
edited
Loading

Here's pull request for one I found: #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jvanasco @agrrh