Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactions with LSP semantic tokens #197

Open
GheTar-home opened this issue Aug 14, 2024 · 0 comments
Open

Interactions with LSP semantic tokens #197

GheTar-home opened this issue Aug 14, 2024 · 0 comments

Comments

@GheTar-home
Copy link

GheTar-home commented Aug 14, 2024

Hello, I've noticed a strange interaction between your themes and Golang / gopls (Golang LSP).

The starting situation was this one:
image

as you can see almost all operators are grey instead of yellow and function arguments are correctly highlighted with a different color from local variables.

Now, VSCode by default uses

"editor.semanticHighlighting.enabled": "configuredByTheme",

and in my settings.json I have configured gopls like this.

"gopls": { "ui.semanticTokens": true },

I'm not an expert on these stuff but it looks like that the LSP gives additional information for themes to use; Like which are the arguments in the function body that, as you can see, works as expected.

I tried to disable the gopls semantic tokens option in settings.json, restart VSCode and there it goes:

image

All operators are yellow instead of grey but function arguments (and I suppose other type of "symbols") are no longer highlighted differently.

I think that this issue might be related to #169

Thanks a lot for your work on these themes, they are the best around.

P.S. : I have just now noticed that you already aknowledged the issue with semantic tokens on #92, sorry for the redundancy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant