Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trivial] update m2cgen to use NumPy 2.0's np.nan convention #592

Open
ssundaresh-thirdpartywatcher opened this issue Jul 29, 2024 · 0 comments

Comments

@ssundaresh-thirdpartywatcher

NumPy 2.0 uses np.nan instead of np.NaN. Numpy 1.x supports both.

Recommend switching to np.nan in the 3 places it is used in m2cgen, in tests/utils.py:
83: [np.nan] * self.X.shape[1],
107: [np.nan] * self.X.shape[1],
120: [np.nan] * self.X.shape[1],

Figured I'd raise this issue for awareness, while I figure out how to properly upstream from our fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant