Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set-nbObject LookUps not working #30

Open
steinbachio opened this issue Oct 30, 2019 · 1 comment
Open

Set-nbObject LookUps not working #30

steinbachio opened this issue Oct 30, 2019 · 1 comment

Comments

@steinbachio
Copy link

In Set-nbObject.ps1

it is checking, if it needs to lookup for the value.

line 111-113:

Is

if ($name -in $lookup.keys) {
    $value = ConvertTo-nbID -source $value -value $name
}

Should be

if ($name -in $lookup.keys) {
    $value = ConvertTo-nbID -source $lookup[$name] -value $value
}

This result in lookups on not existing urls.

@BatmanAMA
Copy link
Owner

You are totally right! Thanks for the report. I'll push out a patch as I have a few other bugs to fix too. Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants