Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

World weapon shots are not colored on radar #287

Open
Ratfink opened this issue Sep 13, 2021 · 0 comments
Open

World weapon shots are not colored on radar #287

Ratfink opened this issue Sep 13, 2021 · 0 comments

Comments

@Ratfink
Copy link

Ratfink commented Sep 13, 2021

World weapon shots can have a team assigned, and appear team-colored in the 3D view. However, they always appear white in the radar, even when coloredradarshots is set. It would be great if they were colored too.

I've made a simple patch to do this by copying the logic for setting the colors of player shots. I plan to make this patch more DRY and send a pull request, but I'm not sure whether to make it against 2.4 or 2.6. It seems like this change could offer some minor advantage to players when teamkilling is disabled, since it's clearer which shots do or do not need to be dodged. I guess that's an argument for only making this change in 2.6, not 2.4, but I don't know if the advantage would be big enough to matter anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant