Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validation of values after calculations to catch errors #119

Open
ROODAY opened this issue Jan 6, 2021 · 0 comments
Open

Improve validation of values after calculations to catch errors #119

ROODAY opened this issue Jan 6, 2021 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed v3.1 Target Release - v3.1

Comments

@ROODAY
Copy link
Member

ROODAY commented Jan 6, 2021

E.g. a recent error with timeslots not showing up in timezones far from EST was due to not applying % 24 to the start and end hours, causing them to be values like 28 (which doesn't make sense for a clock with 24 hours). This led to issues with the slot generation in the ScheduleColumn (which uses minute offsets in a hashmap for fast calculation) as slots ended up being negative (which should never happen). An example fix would be adding a check to this function to ensure that slots are always positive.

There are probably lots of other places throughout the codebase that could benefit from checks like this (where if the check fails throw an error so we can debug easily). We also benefit from rewriting the app to use Typescript (since it's cross-compatible we can have some files in TS and others in plain JS until it's completely rewritten, although this will be a bigger undertaking). Discuss any other places for checks here.

@ROODAY ROODAY added enhancement New feature or request help wanted Extra attention is needed labels Jan 6, 2021
@vitorvicente vitorvicente added the v3.1 Target Release - v3.1 label Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed v3.1 Target Release - v3.1
Projects
None yet
Development

No branches or pull requests

2 participants