Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use fixed table layout #48

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: use fixed table layout #48

wants to merge 2 commits into from

Conversation

tjwelde
Copy link
Contributor

@tjwelde tjwelde commented Oct 13, 2021

fixes KILTProtocol/ticket#1636

This PR proposes a layout change to a fixed table layout.
I changed the width of the input field, so that it looks more balanced.

Only the indicator column, the action column and the tokens column (at the far right) have fixed width. The rest of the width is distributed equally among the other columns.

How to test:

  • Open/Close a collator row
  • stake on a collator to set it active

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

Copy link
Contributor

@Dudleyneedham Dudleyneedham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using the search collators the table completely breaks.

The tr.search seems to cause the issue CollatorsList.module.css line 31.

Additionally, it would be good to include the line for the staking to break up the information to clearly show different actions a user can use. I have a commit ready for this.

@tjwelde
Copy link
Contributor Author

tjwelde commented Oct 19, 2021

Ah, thanks. I will have a look.
Please include the commit here, or in another PR, as you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants