Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two dates in col Date_last_evaluated_ENIGMA of output/release/built_with_change_types.tsv #1366

Open
ramiromagno opened this issue Dec 3, 2021 · 2 comments

Comments

@ramiromagno
Copy link

Hi BRCA Exchange team,

I am trying to read the file output/release/built_with_change_types.tsv from the archive tarball. While trying to parse the column Date_last_evaluated_ENIGMA there are a few cases where the value reads a couple of dates separated by comma instead of a single date:

# A tibble: 4 × 5
    row   col expected        actual                file                                                       
  <int> <int> <chr>           <chr>                 <chr>                                                      
1 26142    11 date in ISO8601 2015-01-12,2016-09-28 output/release/built_with_change_types.tsv
2 51732    11 date in ISO8601 2016-10-18,2017-12-15 output/release/built_with_change_types.tsv
3 53218    11 date in ISO8601 2016-10-18,2017-12-15 output/release/built_with_change_types.tsv
4 55862    11 date in ISO8601 2017-06-29,2016-04-15 output/release/built_with_change_types.tsv

Would it be possible to commit to one of the dates instead?

@ramiromagno
Copy link
Author

The same applies to other date/datetime columns, e.g. Created_date_LOVD and Edited_date_LOVD.

@ramiromagno
Copy link
Author

The explanation of the column DateSignificanceLastEvaluated_ClinVar reads:

List of the dates the clinical significance of the variant was last evaluated (not the date that a patient was evaluated).

Shouldn't it be a single date?

Also, in some cases I find the value "None" in the list of dates, e.g. "2020-06-15,None" or "2013-12-01,2017-12-15,None".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant