Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature request) Other criteria for advancements #20

Open
Olthoo opened this issue Mar 16, 2023 · 5 comments
Open

(Feature request) Other criteria for advancements #20

Olthoo opened this issue Mar 16, 2023 · 5 comments

Comments

@Olthoo
Copy link

Olthoo commented Mar 16, 2023

Instead of explaining with my poor english , here is the advancements's criteria that I can't trigger
Those are really not an issue so you can take as much time as you want. or refuse it all together, those are niche case.

"ender_dragon": {
			"trigger": "minecraft:entity_hurt_player",
			"conditions": {
				"damage": {
					"blocked": true,
					"source_entity": {
						"type": "ender_dragon"
					}
				}
			}
##################################################
"player": [
          {
            "condition": "minecraft:entity_properties",
            "entity": "this",
            "predicate": {
              "type_specific": {
                "type": "player",
                "looking_at": {
                  "type": "minecraft:ender_dragon"
                }
              }
            }
          }
        ]
      },
      "trigger": "minecraft:using_item"
    }
  }
  
##########################################################

"ring_of_the_end": {
			"trigger": "minecraft:location",
			"conditions": {
				"player":  {
					"type_specific": {
						"type": "player",
						"stats": [
							{
								"type": "minecraft:killed",
								"stat": "minecraft:ender_dragon",
								"value": {
									"min": 20
								}
							}
						]
					}
				}
			}
		}
	}
	
##############################################################

"ender_dragon": {
			"trigger": "minecraft:entity_killed_player",
			"conditions": {
				"entity": {
					"type": "ender_dragon"
				}
			}
		}

If you need more precision ask me on discord at Olthoo#0322

@BONNe
Copy link
Member

BONNe commented Apr 3, 2023

I can definitely do the first and the last.

The other... is a bit trickier to do. I definitely have options to detect viewing entities and I have already counter how many dragons are killed, but parsing the advancements is not so simple, as it not only requires to know the involved entities, but also the target item/counter :(

@Olthoo
Copy link
Author

Olthoo commented Apr 4, 2023

I don't know if you can edit statistics of players but if you can you could add a minecraft:ender_dragon kill in the player stats when he kill a minecraft:bentobox_ender_dragon ?

@Olthoo
Copy link
Author

Olthoo commented Apr 4, 2023

I found this plugin that manage to edit player stats, maybe the better option would be to redirect any interaction with minecraft:bentobox_ender_dragon to minecraft:ender_dragon ?

@BONNe
Copy link
Member

BONNe commented Apr 4, 2023

I don't know if you can edit statistics of players but if you can you could add a minecraft:ender_dragon kill in the player stats when he kill a minecraft:bentobox_ender_dragon ?

Don't need plugin for that. Will add it

@Olthoo
Copy link
Author

Olthoo commented Apr 5, 2023

Yup that was just a "proof of concept" :D
if you add this "link" between stats you can probably remove the advancements part of the plugin since it will be double usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants