Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare python SDK for compute TypeSpec migration #38620

Open
Tracked by #1850
live1206 opened this issue Nov 20, 2024 · 6 comments
Open
Tracked by #1850

Compare python SDK for compute TypeSpec migration #38620

live1206 opened this issue Nov 20, 2024 · 6 comments
Assignees
Labels
Compute Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team

Comments

@live1206
Copy link
Member

We are working on the compute TypeSpec migration.
Would like python to verify the SDK generation of the corresponding swagger of the converted TypeSpec.
We have split compute into multiple sub services and done the conversion for each of them.

For instance, Compute sub-service:

@github-actions github-actions bot added Compute Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Attention Workflow: This issue is responsible by Azure service team. labels Nov 20, 2024
Copy link

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @amjads1 @Drewm3 @GabstaMSFT @sandeepraichura @TravisCragg-MSFT.

@msyyc msyyc self-assigned this Nov 20, 2024
@TravisCragg-MSFT TravisCragg-MSFT removed the Service Attention Workflow: This issue is responsible by Azure service team. label Nov 21, 2024
@msyyc
Copy link
Member

msyyc commented Dec 17, 2024

Breakings that may be caused by Typespec migration:

  • AvailabilitySet change inheritance from Resource to TrackedResource
  • Resource removed property location/tags
  • RestorePointSourceVMOSDisk is renamed to RestorePointSourceVmosDisk
  • Enum AvailabilitySetSkuTypes is removed
  • ResourceWithOptionalLocation is removed
  • Some method (e.g. AvailabilitySetsOperations.create_or_update) renamed signature parameters to resource
  • Method VirtualMachineExtensionsOperations.begin_create_or_update/VirtualMachineScaleSetExtensionsOperations.begin_create_or_update/Method VirtualMachineScaleSetVMExtensionsOperations.begin_create_or_update renamed signature extension_parameters to resource
  • Method VirtualMachineScaleSetVMRunCommandsOperations.begin_create_or_update renamed signature run_command to body
  • Method VirtualMachineRunCommandsOperations.begin_create_or_update renamed signatureextension_parameters to body
  • (RemovedOrRenamedClass): Deleted or renamed operation group LogAnalyticsOperations
  • (RemovedOrRenamedClass): Deleted or renamed operation group SshPublicKeysOperations
  • (RemovedOrRenamedClass): Deleted or renamed operation group UsageOperations
  • (RemovedOrRenamedClass): Deleted or renamed operation group VirtualMachineImagesEdgeZoneOperations
  • (RemovedOrRenamedClass): Deleted or renamed operation group VirtualMachineImagesOperations
  • (RemovedOrRenamedClass): Deleted or renamed operation group VirtualMachineScaleSetRollingUpgradesOperations
  • (RemovedOrRenamedClass): Deleted or renamed operation group VirtualMachineScaleSetVMsOperations
  • (RemovedOrRenamedClass): Deleted or renamed operation group VirtualMachineSizesOperations
  • (RemovedOrRenamedClassMethod): Deleted or renamed method VirtualMachinesOperations.list_by_location
  • (RemovedOrRenamedClassMethod): Deleted or renamed method VirtualMachineScaleSetsOperations.list_by_location
  • (RemovedOrRenamedClassMethod): Deleted or renamed method VirtualMachineRunCommandsOperations.get
  • (RemovedOrRenamedClassMethod): Deleted or renamed method VirtualMachineRunCommandsOperations.list

@msyyc
Copy link
Member

msyyc commented Dec 17, 2024

Python SDK domain breakings:

  • flatten
  • Enum NetworkApiVersion renamed TWO_THOUSAND_TWENTY11_01 to ENUM_2020_11_01
  • All header/query signatures changes from positional to keyword only. (expected)
  • (ChangedParameterOrdering): Method VirtualMachineExtensionImagesOperations.list_versions re-ordered its parameters from ['self', 'location', 'publisher_name', 'type', 'filter', 'top', 'orderby', 'kwargs'] to ['self', 'location', 'publisher_name', 'type', '_filter', '_top', '_orderby', 'kwargs'] (track issue [bug] naming breaking when migrate swagger to typespec autorest.python#2979)

@msyyc
Copy link
Member

msyyc commented Dec 17, 2024

Python SDK domain breakings but not influence SDK users:

  • Removed some models (e.g. ComputeOperationValue/ListUsagesResult/VirtualMachineScaleSetListOSUpgradeHistory but not influence SDK users.

@melina5656
Copy link
Member

Hi @msyyc,the issue of the removal of location and tags from the Resource seems to be unchangeable, as it exists in node_modules. Do you have any solutions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compute Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team
Projects
None yet
Development

No branches or pull requests

4 participants