Add schema support for mysql #4783
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saragluna
requested review from
karolz-ms,
wbreza,
vhvb1989,
hemarina,
weikanglim and
JeffreyCA
as code owners
JeffreyCA
reviewed
Feb 12, 2025
| {{- if .DbMySql}} | ||
| var mysqlDatabaseName = '{{ .DbMySql.DatabaseName }}' | ||
| var mysqlDatabaseUser = '{{ .DbMySql.DatabaseUser }}' | ||
| module mysqlServer 'br/public:avm/res/db-for-my-sql/flexible-server:0.4.1' = { |
There was a problem hiding this comment.
Can we use 0.6.1, the latest version?
https://mcr.microsoft.com/v2/bicep/avm/res/db-for-my-sql/flexible-server/tags/list
There was a problem hiding this comment.
Should we also add the password to the keyvault module's secrets like postgres?
There was a problem hiding this comment.
We do generate and set the password currently -- it's done inside the password seeding in scaffold.go
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
weikanglim
reviewed
Feb 15, 2025
| spec.Parameters = append(spec.Parameters, | ||
| Parameter{ | ||
| Name: "mysqlDatabasePassword", | ||
| Value: "$(secretOrRandomPassword ${AZURE_KEY_VAULT_NAME} mysqlDatabasePassword)", |
There was a problem hiding this comment.
Suggested change
| Value: "$(secretOrRandomPassword ${AZURE_KEY_VAULT_NAME} mysqlDatabasePassword)", | |
| Value: "$(secretOrRandomPassword ${AZURE_KEY_VAULT_NAME} MYSQL-PASSWORD)", |
I realized that we may need to update the naming here.
Feel free to update the one for postgres as well. since I'm planning to fix these later
weikanglim
reviewed
Feb 15, 2025
| administratorLogin: mysqlDatabaseUser | ||
| administratorLoginPassword: mysqlDatabasePassword | ||
| geoRedundantBackup: 'Disabled' | ||
| firewallRules: [ |
There was a problem hiding this comment.
I'm not sure why exactly, but when I tried this locally, I ran into some firewall rule issues:
There was a problem hiding this comment.
"network": {
"publicNetworkAccess": "Enabled"
},This setting seems to be important
There was a problem hiding this comment.
Was able to connect after this tweak
weikanglim
reviewed
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #4671, this PR will add the resource support of MySQL database.