Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review null or undefined se/deserialization expression #2855

Open
qiaozha opened this issue Oct 15, 2024 · 0 comments
Open

review null or undefined se/deserialization expression #2855

qiaozha opened this issue Oct 15, 2024 · 0 comments
Labels
HRLC P1 priority 1

Comments

@qiaozha
Copy link
Member

qiaozha commented Oct 15, 2024

Currently, if a property is null or undefined type, we will generate the code as

    functions: !item["functions"]
      ? item["functions"]
      : functionDefinitionArraySerializer(item["functions"]),

which could be problematic if item["functions"] is an empty string or number 0 or boolean false, and it supposed to go into the serialization function logic. Like we get a 0 for timestamp type.

See comment here #2759 (comment)

@qiaozha qiaozha added P1 priority 1 HRLC labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HRLC P1 priority 1
Projects
None yet
Development

No branches or pull requests

1 participant