Rename ci python to ci observability

Call make alerts and ensure no uncommited files exists

Author: janboll

.github/workflows/bicep-lint.yml

@@ -24,7 +24,6 @@ jobs:
         az bicep install -v v0.33.93
         az bicep version
         make fmt
-        make modules/metrics/rules/generatedPrometheusAlertingRules.bicep
         make lint
     - name: Check for uncommitted changes
       working-directory: './dev-infrastructure'

.github/workflows/ci-observability.yml

@@ -0,0 +1,67 @@
+name: 'ci-observability'
+on:
+  pull_request:
+    branches:
+    - main
+    paths:
+    - '.github/workflows/ci-python.yml'
+    - 'observability/**'
+    types:
+    - opened
+    - synchronize
+    - reopened
+    - closed
+jobs:
+  test-grafana-script:
+    runs-on: 'ubuntu-latest'
+    steps:
+    - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+      with:
+        fetch-depth: 1
+    - uses: actions/setup-python@v5
+      with:
+        python-version: '3.9'
+    - run: cd observability/grafana && make test
+    - run: |
+        cd observability/grafana &&
+        pip install black &&
+        make format
+    - run: |
+        if [[ ! -z "$(git status --short)" ]]
+        then
+          echo "there are some modified files, rerun 'make format' to update them and check the changes in"
+          git status
+          exit 1
+        fi
+  test-prometheus-rules:
+    runs-on: 'ubuntu-latest'
+    steps:
+    - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+      with:
+        fetch-depth: 1
+    - name: 'Set up Go'
+      uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5.4.0
+      with:
+        go-version-file: 'go.work'
+        check-latest: true
+    - name: 'Install promtool'
+      run: |
+        cd $(mktemp -d)
+        curl -sfLo - https://github.com/prometheus/prometheus/releases/download/v3.2.1/prometheus-3.2.1.linux-amd64.tar.gz | tar xzf -
+        sudo mv prometheus-3.2.1.linux-amd64/promtool /usr/local/bin/promtool
+        chmod +x /usr/local/bin/promtool
+    - name: 'Make alerts'
+      run: |
+        # https://github.com/actions/runner-images/issues/11987
+        az config set bicep.use_binary_from_path=false
+        az bicep install
+        cd observability &&
+        make alerts
+    - name: 'Ensure all changes are persisted'
+      run: |-
+        if [[ ! -z "$(git status --short)" ]]
+        then
+          echo "there are some modified files, rerun 'make alerts' to update them and check the changes in"
+          git status
+          exit 1
+        fi

.github/workflows/ci-python.yml

@@ -8,3 +8,4 @@ kubernetesControlPlane-prometheusRule:
 alerts: kubernetesControlPlane-prometheusRule
 	make -C ../tooling/prometheus-rules run
 	az bicep format -f $$(yq '.prometheusRules.outputBicep' observability.yaml)
+.PHONY: alerts