Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Objects and arrays get wrong parent if they have text nodes as siblings #320

Open
mahtikebab opened this issue Mar 16, 2023 · 5 comments · May be fixed by #431
Open

[BUG]: Objects and arrays get wrong parent if they have text nodes as siblings #320

mahtikebab opened this issue Mar 16, 2023 · 5 comments · May be fixed by #431
Assignees
Labels
bug Something isn't working

Comments

@mahtikebab
Copy link

Issue description

Hey,
for some reason the text nodes in an object are displayed as the parent of any arrays or objects that should be siblings of the text nodes
Screenshot 2023-03-16 at 13 53 52

Media & Screenshots

No response

Operating system

  • OS: [e.g. iOS]:

  • Browser [e.g. chrome, safari]:

  • Any other details...

Priority this issue should have

High (immediate attention needed)

@mahtikebab mahtikebab added the bug Something isn't working label Mar 16, 2023
@AykutSarac
Copy link
Owner

I don't see anything wrong here, can you elaborate with more details?

@mahtikebab
Copy link
Author

mahtikebab commented Mar 16, 2023

From the graph it looks like the "object" and "array" are children of the node that contains the two text properties. Shouldn't the arrows go from body to "object" and "array" nodes? I.e. for "object" it now goes
body -> textnode -> object
instead of:
body -> object, like it's in the JSON. "object" and "array" are "body"'s children.

If you remove the two text properties from "body" object you get the proper result, i.e.:
image

@mahtikebab
Copy link
Author

@AykutSarac any updates?

@NitinRamnani
Copy link

NitinRamnani commented Apr 17, 2023

I agree with you @mahtikebab. Graph should look like below for given input.

Expected:

image

Current behavior:

image

@NitinRamnani
Copy link

Added a fix : #329

@AykutSarac AykutSarac linked a pull request Dec 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants