fix(select): updating react-select and adding aria-controls to input … #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to fix 508 compliance issues EB-234
JoeSpanbauer
requested review from
jordan-a-young,
LauRoxx and
gregmartDOTin
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1307 +/- ##
==========================================
- Coverage 94.15% 91.21% -2.95%
==========================================
Files 19 20 +1
Lines 599 717 +118
Branches 197 236 +39
==========================================
+ Hits 564 654 +90
- Misses 35 63 +28
|
| @@ -25,7 +25,7 @@ const components = { | |||
| ClearIndicator: () => null, | |||
| Input: (props) => { | |||
| const { 'aria-required': required } = props.selectProps; | |||
| return <Input {...props} aria-required={required} />; | |||
| return <Input aria-controls="" {...props} aria-required={required} />; | |||
There was a problem hiding this comment.
I think we need to be able to pass a value for aria-controls, right?
There was a problem hiding this comment.
The component we're using doesn't support this. aria-controls needs to be the id of the ul, and this package uses divs. Also, the menu isn't rendered until it's expanded, which doesn't resolve the 508 compliance issue.
owolfhu1
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to fix 508 compliance issues EB-234
Before submitting a pull request, please make sure the following is done:
master.yarnin the repository root.yarn test). Tip:yarn test --watch TestNameis helpful in development.