Post meta: Update meta keys to be private #1090
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[Feature] Collections
[Focus] Compatibility
|
@pfefferle I remember you mentioning certain post meta keys that should be private, which ones were those? |
|
It was more about if there are some that should not be private. Like for example the visibility one. So that classic editor users can add that through the meta forms for example. |
WordPress convention states that meta keys prefixed with an underscore are considered private and hidden from the custom fields UI. Since our meta keys are for internal plugin use only, they should follow this convention. This change helps prevent accidental modification of ActivityPub meta data through WordPress's custom fields interface while maintaining the expected pattern for plugin developers. See: https://developer.wordpress.org/plugins/metadata/managing-post-metadata/#hidden-custom-fields
Needs to be editable in editor
obenland
force-pushed
the
update/private-post-meta-keys
branch
from
edfd9b5 to
cbf88af
Compare
pfefferle
previously approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WordPress convention states that meta keys prefixed with an underscore are considered private and hidden from the custom fields UI. Since our meta keys are for internal plugin use only, they should follow this convention.
This change helps prevent accidental modification of ActivityPub meta data through WordPress's custom fields interface while maintaining the expected pattern for plugin developers.
See: https://developer.wordpress.org/plugins/metadata/managing-post-metadata/#hidden-custom-fields
Fixes #943
Proposed changes:
class-test-followers.phpto use the new prefixed meta keys (activitypub*)class-test-migration.phpto test the migration directly instead of throughmaybe_migrate()activitypub_user_id→_activitypub_user_id)Other information:
Testing instructions: