Add/event objects #629

Menrath · 2024-01-02T20:42:04Z

I started this pull request as a minimal one, with only adding an Event class but I ended up also shaping the way the Json-LD context is build a bit. It is now tied to the ActivityPub objects.

Reason: Don't store and send context which is never referenced.

- change the propertyname which stores the json-ld context from context to _context, because context is already reserved in the ActivityStreams vocabulary. - cleanup currently unused code

pfefferle · 2024-01-03T08:31:23Z

The context handling is a bit complicated and confusing.

Can we maybe find a way to have only the context attribute and work with set_context to replace it and add_context to extend it instead of using _context?

templates/author-json.php

Menrath · 2024-01-03T08:43:16Z

Or maybe don't use a property for the JsonLD context at all, just use a getter function called "get_json_ld_context".
Then there should be no confusion between the jsonld-context ('@context') and the term context ('context') from the ActivityStreams.

pfefferle · 2024-01-03T08:46:00Z

Ah, that is the difference! Makes sense!

Then I would really vote for having it only as const and think about how to handle it in to_array and to_json methods!

…rite the array in transformers.

includes/activity/class-postal-address.php

… function get_json_ld_context()

… the JsonLD context

@context

This allows to not set the @context in the resulting array.

…_array function

includes/activity/class-base-object.php

…t-objects

Menrath · 2024-01-05T15:07:10Z

Converted it to draft to signalize that there is no hurry and we might discover some little enhancements in the next few weeks anyway!

…b-namespace

seems it should not be used as a namespace either

includes/transformer/class-base.php

Co-authored-by: Matthias Pfefferle <[email protected]>

…vitypub into add/event-objects

We already set the correct user with `$transformer->change_wp_user_id( $user_id );` so the Actor will be generated properly. We can change the behaviour, but we should not use both.

this should stay as is, because it pre-fills the Activity with data (for example cc and to) and it will no longer be done with your change. It is on purpose that it first sets the object and then replaces it with the URI. See: https://github.com/Automattic/wordpress-activitypub/blob/master/includes/activity/class-activity.php#L195

includes/activity/class-base-object.php

pfefferle · 2024-01-17T09:19:43Z

@Menrath I added some changes, can you verify them and I had one more inline question!

Menrath

e8db7e9
Great that you saw that, it was probably a leftover before the function change_wp_user_id was available: Mobilizon currently requires the actor attribute also on the event object itself, although it is against the ActivityPub standard.

includes/rest/class-outbox.php

templates/author-json.php

includes/activity/class-base-object.php

includes/activity/class-postal-address.php

includes/activity/class-base-object.php

includes/rest/class-collection.php

includes/activity/class-base-object.php

…de it.

Menrath · 2024-01-17T16:59:16Z

@pfefferle Thanks for your review again! Looks good to me!

A slightly off topic last question that comes to my mind: what about calling the to_object function to_activitypub_object? For improving searchability of the where it's used.

to be consistent with folder names in singular

Menrath

LGTM

includes/activity/class-base-object.php

pfefferle

oops 😳

thanks!

@Menrath

I hope this is fine, to have the complete plugin under the MIT @Menrath ?!?

Menrath

Mixed licensing. I have no experience to be honest. I am fine with it. Our extensions plugin will be AGPLv3 only though :)

carstingaxion · 2024-02-13T23:13:55Z

What an enormous PR! Congrats and Thank you very much for your contribution @Menrath and @pfefferle

… and all this even without an issue ;)

Menrath added 4 commits January 2, 2024 17:22

remove redundant property definitions

564ea85

Add redused context for actors.

bef8ce5

Add classes to construct Moblizon compatible events

700494a

Bind the context to the activitypub object

1f89d90

- change the propertyname which stores the json-ld context from context to _context, because context is already reserved in the ActivityStreams vocabulary. - cleanup currently unused code

github-actions bot added the OSS Citizen label Jan 2, 2024

fix phpcs

847d4d0

pfefferle reviewed Jan 3, 2024

View reviewed changes

templates/author-json.php Show resolved Hide resolved

Remove PostalAddress object: it's enough (at least atm) to directly w…

f1a25c3

…rite the array in transformers.

pfefferle reviewed Jan 3, 2024

View reviewed changes

includes/activity/class-postal-address.php Outdated Show resolved Hide resolved

Menrath added 9 commits January 3, 2024 10:36

Remove _context property from ActivityPub objects in favour of getter…

15c1f03

… function get_json_ld_context()

fix unit tests: ActivityPub Activity objects have a custom getter for…

0d3ff18

… the JsonLD context

fix phpcs

aa1214d

fix unit-tests to also support php5.6

7f73253

fix phpcs

8ad599e

add param include_json_ld_context to to_array function

e00b6b3

This allows to not set the @context in the resulting array.

propagate the param include_json_ld_context to nested calls of to_array.

2e2e0d9

fix phpcs

93265c3

Nested AcitivityPub objects: never build context in inner items in to…

4f18d9a

…_array function

pfefferle reviewed Jan 3, 2024

View reviewed changes

includes/activity/class-base-object.php Show resolved Hide resolved

Menrath added 2 commits January 5, 2024 12:11

Merge commit '4c297acfd454a13260900ff0f97a9e3f425e960c' into add/even…

b7a9045

…t-objects

fix: param of set_address may also be an array

9f25e0a

Menrath marked this pull request as draft January 5, 2024 15:06

fix typo in comment

e76d2d5

github-actions bot added the [Status] In Progress label Jan 13, 2024

Menrath added 2 commits January 14, 2024 09:11

always prefix json-ld context with json-ld and move event class to su…

b76820e

…b-namespace

fix usage of reserved object keyword

960ed53

seems it should not be used as a namespace either

pfefferle reviewed Jan 15, 2024

View reviewed changes

includes/transformer/class-base.php Show resolved Hide resolved

Menrath and others added 9 commits January 15, 2024 18:03

Fix calling non-static function as static

7105c56

Co-authored-by: Matthias Pfefferle <[email protected]>

Partly fix Json-LD contexts in collections

68a82cb

Merge branch 'add/event-objects' of github.com:Menrath/wordpress-acti…

9ea5ddf

…vitypub into add/event-objects

Update includes/activity/class-base-object.php

ae65b76

this is implicit

e8db7e9

We already set the correct user with `$transformer->change_wp_user_id( $user_id );` so the Actor will be generated properly. We can change the behaviour, but we should not use both.

add $include_json_ld_context support to to_json

76be832

disable some more contexts

24bbd07

remove whitespace

14145fc

pfefferle reviewed Jan 17, 2024

View reviewed changes

includes/activity/class-base-object.php Show resolved Hide resolved

Menrath commented Jan 17, 2024

View reviewed changes

Menrath added 2 commits January 17, 2024 17:38

Add php-comment for 7ed17c0

6728d74

Fix JSON-LD context for ActivityPub objects: child classes may overri…

4957294

…de it.

Menrath force-pushed the add/event-objects branch from e667b76 to 4957294 Compare January 17, 2024 16:53

pfefferle added 3 commits January 17, 2024 19:34

coding standards

278c8da

Merge branch 'master' into add/event-objects

b97d79d

call folder/namespace Extended_Object

ddd1956

to be consistent with folder names in singular

Menrath commented Jan 18, 2024

View reviewed changes

includes/activity/class-base-object.php Show resolved Hide resolved

fix: unnessesary nesting of extended-objects

403049b

pfefferle reviewed Jan 18, 2024

View reviewed changes

pfefferle added 2 commits January 18, 2024 15:48

remove license

5bebaf1

I hope this is fine, to have the complete plugin under the MIT @Menrath ?!?

Merge branch 'master' into add/event-objects

0d090e7

Menrath commented Jan 18, 2024

View reviewed changes

pfefferle approved these changes Jan 18, 2024

View reviewed changes

pfefferle merged commit 174262d into Automattic:master Jan 18, 2024
10 checks passed

github-actions bot removed the [Status] In Progress label Jan 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add/event objects #629

Add/event objects #629

Menrath commented Jan 2, 2024

pfefferle commented Jan 3, 2024

Menrath commented Jan 3, 2024

pfefferle commented Jan 3, 2024 •

edited

Loading

Menrath commented Jan 5, 2024

pfefferle commented Jan 17, 2024

Menrath left a comment •

edited

Loading

Menrath commented Jan 17, 2024 •

edited

Loading

Menrath left a comment

pfefferle left a comment

Menrath left a comment •

edited

Loading

carstingaxion commented Feb 13, 2024 •

edited

Loading

Add/event objects #629

Add/event objects #629

Conversation

Menrath commented Jan 2, 2024

pfefferle commented Jan 3, 2024

Menrath commented Jan 3, 2024

pfefferle commented Jan 3, 2024 • edited Loading

Menrath commented Jan 5, 2024

pfefferle commented Jan 17, 2024

Menrath left a comment • edited Loading

Choose a reason for hiding this comment

Menrath commented Jan 17, 2024 • edited Loading

Menrath left a comment

Choose a reason for hiding this comment

pfefferle left a comment

Choose a reason for hiding this comment

Menrath left a comment • edited Loading

Choose a reason for hiding this comment

carstingaxion commented Feb 13, 2024 • edited Loading

pfefferle commented Jan 3, 2024 •

edited

Loading

Menrath left a comment •

edited

Loading

Menrath commented Jan 17, 2024 •

edited

Loading

Menrath left a comment •

edited

Loading

carstingaxion commented Feb 13, 2024 •

edited

Loading