Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some CSS fixes for the reactions block #1108

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Some CSS fixes for the reactions block #1108

merged 5 commits into from
Dec 20, 2024

Conversation

pfefferle
Copy link
Member

@pfefferle pfefferle commented Dec 20, 2024

This should fix the interference with the Webmention plugin and fix #1106

Can you maybe test the changes with your theme @jeherve ?

Proposed changes:

Screenshot 2024-12-20 at 10 13 43 Screenshot 2024-12-20 at 10 13 58 Screenshot 2024-12-20 at 10 14 12 Screenshot 2024-12-20 at 10 14 28 Screenshot 2024-12-20 at 10 15 34

@github-actions github-actions bot added the [Focus] Editor Changes to the ActivityPub experience in the block editor label Dec 20, 2024
@pfefferle pfefferle changed the title Some CSS fixes for the reactions list Some CSS fixes for the reactions block Dec 20, 2024
@pfefferle pfefferle requested review from jeherve and a team December 20, 2024 09:26
@pfefferle pfefferle self-assigned this Dec 20, 2024
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you maybe test the changes with your theme @jeherve ?

It updated the main link color, but not the one in the modal:
image

You can see it live at https://herve.bzh/20241218-15277/

@pfefferle
Copy link
Member Author

@jeherve Can you tell me the theme you are using?!

@jeherve
Copy link
Member

jeherve commented Dec 20, 2024

Can you tell me the theme you are using?!

That's Hey.

I don't seem to notice a difference with your last push.

image

@pfefferle pfefferle marked this pull request as draft December 20, 2024 13:23
@obenland
Copy link
Member

@jeherve When you get a chance, could you try again with ea8116e now in place?

pfefferle and others added 5 commits December 20, 2024 08:24
@obenland obenland marked this pull request as ready for review December 20, 2024 14:36
@pfefferle pfefferle merged commit c7026f8 into trunk Dec 20, 2024
25 checks passed
@pfefferle pfefferle deleted the fix/reactions-css branch December 20, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Editor Changes to the ActivityPub experience in the block editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reactions Block: link color conflicts with dark themes
3 participants